some issues with emacs 25

classic Classic list List threaded Threaded
27 messages Options
12
Matthew Lear Matthew Lear
Reply | Threaded
Open this post in threaded view
|

Re: some issues with emacs 25

On 18 Feb 2017 01:01, "David Bremner" <[hidden email]> wrote:

So I _finally_ got around to looking at these, and I think it's roughly
the same shr bug as before but some different functions.

I could actually only duplicate the bug with emacs-reply-fail-ec
message, but that was fixed by the following patch against the emacs-25
branch. Does this patch fix both failures for you?

diff --git a/lisp/net/shr.el b/lisp/net/shr.el
index 6c35a33c9c..2bc37c64bd 100644
--- a/lisp/net/shr.el
+++ b/lisp/net/shr.el
@@ -1993,6 +1993,9 @@ shr-pixel-buffer-width
     (if (get-buffer-window)
        (car (window-text-pixel-size nil (point-min) (point-max)))
       (save-window-excursion
+        ;; Avoid errors if the selected window is a dedicated one,
+        ;; and they just want to insert a document into it.
+        (set-window-dedicated-p nil nil)
        (set-window-buffer nil (current-buffer))
        (car (window-text-pixel-size nil (point-min) (point-max)))))))

@@ -2036,6 +2039,9 @@ shr-render-td-1
            (shr-indentation 0))
        (shr-descend dom))
       (save-window-excursion
+        ;; Avoid errors if the selected window is a dedicated one,
+        ;; and they just want to insert a document into it.
+        (set-window-dedicated-p nil nil)
        (set-window-buffer nil (current-buffer))
        (unless fill
          (setq natural-width

Thanks David. Yes it does. After recompiling the v25 lisp with these changes, I'm unable to reproduce the problems with both the test emails I sent you. Wonderful :-)
Are you going to raise this with upstream?
Cheers, 
 Matt 

_______________________________________________
notmuch mailing list
[hidden email]
https://notmuchmail.org/mailman/listinfo/notmuch
David Bremner-2 David Bremner-2
Reply | Threaded
Open this post in threaded view
|

Re: some issues with emacs 25

Matthew Lear <[hidden email]> writes:


> Thanks David. Yes it does. After recompiling the v25 lisp with these
> changes, I'm unable to reproduce the problems with both the test emails I
> sent you. Wonderful :-)
> Are you going to raise this with upstream?
> Cheers,
>  Matt

Yes, I've filed

     https://debbugs.gnu.org/cgi/bugreport.cgi?bug=25828

_______________________________________________
notmuch mailing list
[hidden email]
https://notmuchmail.org/mailman/listinfo/notmuch
David Bremner-2 David Bremner-2
Reply | Threaded
Open this post in threaded view
|

Re: some issues with emacs 25

David Bremner <[hidden email]> writes:

> Matthew Lear <[hidden email]> writes:
>
>
>> Thanks David. Yes it does. After recompiling the v25 lisp with these
>> changes, I'm unable to reproduce the problems with both the test emails I
>> sent you. Wonderful :-)
>> Are you going to raise this with upstream?
>> Cheers,
>>  Matt
>
> Yes, I've filed
>
>      https://debbugs.gnu.org/cgi/bugreport.cgi?bug=25828
>

That bug should be fixed in emacs master branch.

d
_______________________________________________
notmuch mailing list
[hidden email]
https://notmuchmail.org/mailman/listinfo/notmuch
Matthew Lear Matthew Lear
Reply | Threaded
Open this post in threaded view
|

Re: some issues with emacs 25

On 4 Mar 2017 11:03, "David Bremner" <[hidden email]> wrote:
David Bremner <[hidden email]> writes:

> Matthew Lear <[hidden email]> writes:
>
>
>> Thanks David. Yes it does. After recompiling the v25 lisp with these
>> changes, I'm unable to reproduce the problems with both the test emails I
>> sent you. Wonderful :-)
>> Are you going to raise this with upstream?
>> Cheers,
>>  Matt
>
> Yes, I've filed
>
>      https://debbugs.gnu.org/cgi/bugreport.cgi?bug=25828
>

That bug should be fixed in emacs master branch.

d

It was indeed fixed...that is until I updated my emacs git tree to 25.2.1. I've given up composing emails in new frames as it's now broken again - this time when replying to emails which have quoted/embedded html in the body. Feels like two steps forward, one step back :-(
--  Matt


_______________________________________________
notmuch mailing list
[hidden email]
https://notmuchmail.org/mailman/listinfo/notmuch
David Bremner-2 David Bremner-2
Reply | Threaded
Open this post in threaded view
|

Re: some issues with emacs 25

Matthew Lear <[hidden email]> writes:


> It was indeed fixed...that is until I updated my emacs git tree to 25.2.1.
> I've given up composing emails in new frames as it's now broken again -
> this time when replying to emails which have quoted/embedded html in the
> body. Feels like two steps forward, one step back :-(
> --  Matt

Unfortunately I don't have easy access to emacs25.2; I've been waiting
for it show up in Debian. Can you see if the relevant fix referenced in
that bug log included in 25.2? I did wonder if maybe you had a local
modification that was lost when you updated to 25.2.

d
_______________________________________________
notmuch mailing list
[hidden email]
https://notmuchmail.org/mailman/listinfo/notmuch
Matthew Lear Matthew Lear
Reply | Threaded
Open this post in threaded view
|

Re: some issues with emacs 25

Hi David. Finally got back round to checking this with recent sw. Apologies for the long delay. I can confirm that the problem still exists as before, ie replying to my test html emails when composing the message in a new frame throws the bodypart errors. ...But I'm not too fussed about it because I've got used to not composing messages in new frames ;-)
 
I've synced my emacs.git to:
* c3ff6712ad -  (HEAD, origin/emacs-25) * lisp/net/tls.el (tls-program): Fix :version (do not merge to master). (2017-09-14 16:38:29 -0400) <Glenn Morris>

Emacs version is reported as 25.3.50.1.

And notmuch.git to:
* ab8b40f7 -  (HEAD -> master, origin/master, origin/HEAD) cli: make notmuch count --exclude a boolean argument (2017-10-15 19:22:40 -0300) <Jani Nikula>

Using the tiny .emacs below is enough to trigger the problem:

(require 'shr)
(setq mm-text-html-renderer 'shr)
(setq mime-view-text/html-previewer 'shr)
(setq mm-html-inhibit-images nil)
(setq mm-html-blocked-images nil)
(require 'notmuch)
(setq notmuch-mua-compose-in 'new-frame)
(setq notmuch-multipart/alternative-discouraged '("text/plain"))

Not sure what you'd like to do with this from here...
Cheers,
--  Matt

On Fri, Jun 30, 2017 at 1:47 PM, David Bremner <[hidden email]> wrote:
Matthew Lear <[hidden email]> writes:


> It was indeed fixed...that is until I updated my emacs git tree to 25.2.1.
> I've given up composing emails in new frames as it's now broken again -
> this time when replying to emails which have quoted/embedded html in the
> body. Feels like two steps forward, one step back :-(
> --  Matt

Unfortunately I don't have easy access to emacs25.2; I've been waiting
for it show up in Debian. Can you see if the relevant fix referenced in
that bug log included in 25.2? I did wonder if maybe you had a local
modification that was lost when you updated to 25.2.

d


_______________________________________________
notmuch mailing list
[hidden email]
https://notmuchmail.org/mailman/listinfo/notmuch
David Bremner-2 David Bremner-2
Reply | Threaded
Open this post in threaded view
|

Re: some issues with emacs 25

In reply to this post by Matthew Lear
Matthew Lear <[hidden email]> writes:

> I'm of the opinion that this is probably some sort of set up /
> configuration issue specific to 25, but I'm quite surprised. I don't
> have many settings for handling html stuff:
>
> (setq mm-text-html-renderer 'shr)
> (setq shr-inhibit-images nil)
> (setq mime-view-text/html-previewer 'shr)
> (setq mm-inline-text-html-with-images t)
> (setq notmuch-multipart/alternative-discouraged '("text/plain"))
>
> Is this reproducible for anyone else with notmuch from git/master as of
> today?

According to emacs upstream, this problem (or at least my reduced test
case) is fixed in emacs 26.1

      https://debbugs.gnu.org/cgi/bugreport.cgi?bug=29273

Can you confirm that?
_______________________________________________
notmuch mailing list
[hidden email]
https://notmuchmail.org/mailman/listinfo/notmuch
12