Quantcast

notmuch-0.24.1: missing header include

classic Classic list List threaded Threaded
3 messages Options
Thomas Klausner Thomas Klausner
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

notmuch-0.24.1: missing header include

Hi!

On Solaris, notmuch-0.24.1 does not compile because lib/message.cc
uses index(3) but does not include strings.h.

Please apply the attached patch or a similar one.

Thanks,
 Thomas

_______________________________________________
notmuch mailing list
[hidden email]
https://notmuchmail.org/mailman/listinfo/notmuch

patch-lib_notmuch-private.h (406 bytes) Download Attachment
David Bremner-2 David Bremner-2
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: notmuch-0.24.1: missing header include

Thomas Klausner <[hidden email]> writes:

> Hi!
>
> On Solaris, notmuch-0.24.1 does not compile because lib/message.cc
> uses index(3) but does not include strings.h.
>
> Please apply the attached patch or a similar one.
>
> Thanks,
>  Thomas

In master we've replaced index(3) with strchr(3). Does that fix your
issue, or is the include still needed?

d
_______________________________________________
notmuch mailing list
[hidden email]
https://notmuchmail.org/mailman/listinfo/notmuch
Thomas Klausner Thomas Klausner
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: notmuch-0.24.1: missing header include

On Sat, May 13, 2017 at 07:54:39PM -0300, David Bremner wrote:

> > On Solaris, notmuch-0.24.1 does not compile because lib/message.cc
> > uses index(3) but does not include strings.h.
> >
> > Please apply the attached patch or a similar one.
> >
> > Thanks,
> >  Thomas
>
> In master we've replaced index(3) with strchr(3). Does that fix your
> issue, or is the include still needed?

Since you already include <string.h> that's fine.

Thanks,
 Thomas
_______________________________________________
notmuch mailing list
[hidden email]
https://notmuchmail.org/mailman/listinfo/notmuch
Loading...