be more honest about test suite failures due to old libraries
We have several places where tests are skipped or marked as though
some test suite prereqs are missing, but in fact are due to building
against older versions of libraries that don't support certain
This series tries to be more honest about some of those tests by
marking them as broken, rather than just skipping them.
The series still doesn't address T650-regexp-query.sh, which is
basically entirely skipped if Xapian doesn't have a field processor,
rather than marked as broken. But it's still an improvement in
overall test suite honesty over the status quo.
[PATCH 1/3] test: searching by absolute date is broken without Xapian FieldProcessor
Previously, the test suite had simply silently skipped the absolute
date test if we're using an archaic version of Xapian. For
correctness, we should instead mark the test as broken.
This also changes from string to numeric comparison when checking
NOMTUCH_HAVE_XAPIAN_FIELD_PROCESSOR for consistency with other tests.
test/T500-search-date.sh | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/test/T500-search-date.sh b/test/T500-search-date.sh
index 5c5b99a0..f84b0962 100755
@@ -12,11 +12,12 @@ test_begin_subtest "Absolute date range with 'same' operator"
output=$(notmuch search date:2010-12-16..! | notmuch_search_sanitize)
test_expect_equal "$output" "thread:XXX 2010-12-16 [1/1] Olivier Berger; Essai accentué (inbox unread)"
Named queries don't work without Xapian FieldProcessor. Rather than
silently skipping them, we should explictly mark them as broken when
building against an older version of Xapian.
test/T600-named-queries.sh | 33 ++++++++++++++++++++-------------
1 file changed, 20 insertions(+), 13 deletions(-)
If we're building against a version of Xapian that doesn't offer
retrying the lock, we should be honest and describe the tests as
broken, rather than marking them as missing a test prerequisite.
missing test prerequisites should be for specific components of the
test harness that are missing, not for the backend library notmuch
test/T620-lock.sh | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)
> We have several places where tests are skipped or marked as though
> some test suite prereqs are missing, but in fact are due to building
> against older versions of libraries that don't support certain
> This series tries to be more honest about some of those tests by
> marking them as broken, rather than just skipping them.