[WIP PATCH] test: make test-serially to run test serially

classic Classic list List threaded Threaded
2 messages Options
Tomi Ollila-2 Tomi Ollila-2
Reply | Threaded
Open this post in threaded view
|

[WIP PATCH] test: make test-serially to run test serially

This is easier and less error prone than mistyping NOTMUCH_TEST_SERIALIZE
manually from command line (mistype make test-serially and it just doesn't
work)
---

quick first version. this works, but someone(tm) w/ native english experience
could say how the naming sounds like...

 test/Makefile.local | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/test/Makefile.local b/test/Makefile.local
index 47244e8f0956..3c5e7e9cf33b 100644
--- a/test/Makefile.local
+++ b/test/Makefile.local
@@ -76,6 +76,9 @@ else
 endif
 endif
 
+test-serially: export NOTMUCH_TEST_SERIALIZE=t
+test-serially: test
+
 check: test
 
 SRCS := $(SRCS) $(test_srcs)
--
2.13.3

_______________________________________________
notmuch mailing list
[hidden email]
https://notmuchmail.org/mailman/listinfo/notmuch
Daniel Kahn Gillmor Daniel Kahn Gillmor
Reply | Threaded
Open this post in threaded view
|

Re: [WIP PATCH] test: make test-serially to run test serially

On Wed 2019-05-08 19:46:25 +0300, Tomi Ollila wrote:
> This is easier and less error prone than mistyping NOTMUCH_TEST_SERIALIZE
> manually from command line (mistype make test-serially and it just doesn't
> work)
> ---
>
> quick first version. this works, but someone(tm) w/ native english experience
> could say how the naming sounds like...

This is an unusual use of make in my experience (i'm not used to seeing
variables exported in what looks like a rule dependency line), but i'm
not particularly fluent in make in the first place, so take that with a
grain of salt.

As a native en_US speaker, i have no problem with "make test-serially"
(though my usual idiom is to invoke the test suite with "make check" for
some reason).

But if this is useful for even one person who actively cares about the
notmuch codebase (Tomi), i think it should be merged.

        --dkg

_______________________________________________
notmuch mailing list
[hidden email]
https://notmuchmail.org/mailman/listinfo/notmuch

signature.asc (233 bytes) Download Attachment