[PATCH] test: session keys are known broken without session key support

classic Classic list List threaded Threaded
3 messages Options
Daniel Kahn Gillmor Daniel Kahn Gillmor
Reply | Threaded
Open this post in threaded view
|

[PATCH] test: session keys are known broken without session key support

If the version of GMime we're building against doesn't support session
key extraction or re-use, mark the tests that rely on session key
capabilities as known-broken.

This should resolve test suite failures on ubuntu trusty and debian
jessie and earlier, which have GMime 2.6.20 -- session key support was
introduced in GMime 2.6.21.
---
 test/T357-index-decryption.sh | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/test/T357-index-decryption.sh b/test/T357-index-decryption.sh
index 11ea2074..3efaa61f 100755
--- a/test/T357-index-decryption.sh
+++ b/test/T357-index-decryption.sh
@@ -183,6 +183,9 @@ EOF
 notmuch reindex --try-decrypt id:[hidden email]
 output=$(notmuch search sekrit)
 expected='thread:0000000000000001   2016-12-22 [1/1] Daniel Kahn Gillmor; encrypted message (encrypted inbox unread)'
+if [ $NOTMUCH_HAVE_GMIME_SESSION_KEYS -eq 0 ]; then
+    test_subtest_known_broken
+fi
 test_expect_equal \
     "$output" \
     "$expected"
--
2.15.0

_______________________________________________
notmuch mailing list
[hidden email]
https://notmuchmail.org/mailman/listinfo/notmuch
Daniel Kahn Gillmor Daniel Kahn Gillmor
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] test: session keys are known broken without session key support

On Tue 2017-12-05 13:40:27 -0500, Daniel Kahn Gillmor wrote:
> If the version of GMime we're building against doesn't support session
> key extraction or re-use, mark the tests that rely on session key
> capabilities as known-broken.
>
> This should resolve test suite failures on ubuntu trusty and debian
> jessie and earlier, which have GMime 2.6.20 -- session key support was
> introduced in GMime 2.6.21.

This should fix the current travis build failure.  If it's accepted,
i'll use the same technique to mark other tests in my session-keys
series as dependent upon session-key capability.

       --dkg
_______________________________________________
notmuch mailing list
[hidden email]
https://notmuchmail.org/mailman/listinfo/notmuch
David Bremner-2 David Bremner-2
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] test: session keys are known broken without session key support

Daniel Kahn Gillmor <[hidden email]> writes:

> On Tue 2017-12-05 13:40:27 -0500, Daniel Kahn Gillmor wrote:
>> If the version of GMime we're building against doesn't support session
>> key extraction or re-use, mark the tests that rely on session key
>> capabilities as known-broken.
>>
>> This should resolve test suite failures on ubuntu trusty and debian
>> jessie and earlier, which have GMime 2.6.20 -- session key support was
>> introduced in GMime 2.6.21.
>
> This should fix the current travis build failure.  If it's accepted,
> i'll use the same technique to mark other tests in my session-keys
> series as dependent upon session-key capability.

pushed,

d
_______________________________________________
notmuch mailing list
[hidden email]
https://notmuchmail.org/mailman/listinfo/notmuch