[PATCH] test: add a known broken test for S/MIME decryption

classic Classic list List threaded Threaded
3 messages Options
David Bremner-2 David Bremner-2
Reply | Threaded
Open this post in threaded view
|

[PATCH] test: add a known broken test for S/MIME decryption

This should serve to clarify this feature is not implimented in
notmuch yet.
---
 test/T355-smime.sh | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/test/T355-smime.sh b/test/T355-smime.sh
index 336da917..11a4d6cd 100755
--- a/test/T355-smime.sh
+++ b/test/T355-smime.sh
@@ -94,4 +94,13 @@ Verification successful
 EOF
 test_expect_equal_file EXPECTED OUTPUT
 
+test_begin_subtest "Decryption (notmuch CLI)"
+test_subtest_known_broken
+notmuch show --decrypt=true subject:"test encrypted message 001" |\
+    grep "^This is a" > OUTPUT
+cat <<EOF > EXPECTED
+This is a test encrypted message.
+EOF
+test_expect_equal_file EXPECTED OUTPUT
+
 test_done
--
2.24.0

_______________________________________________
notmuch mailing list
[hidden email]
https://notmuchmail.org/mailman/listinfo/notmuch
Daniel Kahn Gillmor Daniel Kahn Gillmor
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] test: add a known broken test for S/MIME decryption

On Sun 2019-11-17 21:58:12 -0400, David Bremner wrote:

> This should serve to clarify this feature is not implimented in
> notmuch yet.
> ---
>  test/T355-smime.sh | 9 +++++++++
>  1 file changed, 9 insertions(+)
>
> diff --git a/test/T355-smime.sh b/test/T355-smime.sh
> index 336da917..11a4d6cd 100755
> --- a/test/T355-smime.sh
> +++ b/test/T355-smime.sh
> @@ -94,4 +94,13 @@ Verification successful
>  EOF
>  test_expect_equal_file EXPECTED OUTPUT
>  
> +test_begin_subtest "Decryption (notmuch CLI)"
> +test_subtest_known_broken
> +notmuch show --decrypt=true subject:"test encrypted message 001" |\
> +    grep "^This is a" > OUTPUT
> +cat <<EOF > EXPECTED
> +This is a test encrypted message.
> +EOF
> +test_expect_equal_file EXPECTED OUTPUT
> +
>  test_done
This looks good to me.  I suspect that when we get full PKCS#7
decryption support, we'll want to use keys and certificates slightly
more sophisticated than the ones in this change (e.g. using the keys and
certs from https://www.ietf.org/id/draft-dkg-lamps-samples-01.html), but
the proposed patch here is a good placeholder that documents the current
state of play. And we can always update the test later as the new
functionality comes in.

Please merge!

       --dkg

_______________________________________________
notmuch mailing list
[hidden email]
https://notmuchmail.org/mailman/listinfo/notmuch

signature.asc (233 bytes) Download Attachment
David Bremner-2 David Bremner-2
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] test: add a known broken test for S/MIME decryption

In reply to this post by David Bremner-2
David Bremner <[hidden email]> writes:

> This should serve to clarify this feature is not implimented in
> notmuch yet.

Applied to master

d
_______________________________________________
notmuch mailing list
[hidden email]
https://notmuchmail.org/mailman/listinfo/notmuch