[PATCH] tag: remove unused attribute from notmuch_tag_command() arguments

classic Classic list List threaded Threaded
4 messages Options
Dmitry Kurochkin Dmitry Kurochkin
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate
star

[PATCH] tag: remove unused attribute from notmuch_tag_command() arguments

Argc and argv arguments are used in notmuch_tag_command() function.
So unused attribute is not appropriate for them.
---
 notmuch-tag.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/notmuch-tag.c b/notmuch-tag.c
index 44fd61f..36b9b09 100644
--- a/notmuch-tag.c
+++ b/notmuch-tag.c
@@ -111,7 +111,7 @@ _optimize_tag_query (void *ctx, const char *orig_query_string, char *argv[],
 }
 
 int
-notmuch_tag_command (void *ctx, unused (int argc), unused (char *argv[]))
+notmuch_tag_command (void *ctx, int argc, char *argv[])
 {
     int *add_tags, *remove_tags;
     int add_tags_count = 0;
--
1.7.8.3

_______________________________________________
notmuch mailing list
[hidden email]
http://notmuchmail.org/mailman/listinfo/notmuch
David Bremner-2 David Bremner-2
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate
star

Re: [PATCH] tag: remove unused attribute from notmuch_tag_command() arguments

On Sat, 28 Jan 2012 12:02:33 +0400, Dmitry Kurochkin <[hidden email]> wrote:
> Argc and argv arguments are used in notmuch_tag_command() function.
> So unused attribute is not appropriate for them.

pushed,

d
_______________________________________________
notmuch mailing list
[hidden email]
http://notmuchmail.org/mailman/listinfo/notmuch
Dmitry Kurochkin Dmitry Kurochkin
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate
star

Re: [PATCH] tag: remove unused attribute from notmuch_tag_command() arguments

On Sat, 04 Feb 2012 07:37:45 -0500, David Bremner <[hidden email]> wrote:
> On Sat, 28 Jan 2012 12:02:33 +0400, Dmitry Kurochkin <[hidden email]> wrote:
> > Argc and argv arguments are used in notmuch_tag_command() function.
> > So unused attribute is not appropriate for them.
>
> pushed,
>

Are you sure?  I do not see it in master.

Regards,
  Dmitry

> d
_______________________________________________
notmuch mailing list
[hidden email]
http://notmuchmail.org/mailman/listinfo/notmuch
David Bremner-2 David Bremner-2
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate
star

Re: [PATCH] tag: remove unused attribute from notmuch_tag_command() arguments

On Sun, 05 Feb 2012 23:34:44 +0400, Dmitry Kurochkin <[hidden email]> wrote:
>
> Are you sure?  I do not see it in master.
>

Oops. Should be there now.

d
_______________________________________________
notmuch mailing list
[hidden email]
http://notmuchmail.org/mailman/listinfo/notmuch
Loading...