[PATCH] remove debian-build/ and its children when cleaning after debian package

classic Classic list List threaded Threaded
4 messages Options
Daniel Kahn Gillmor Daniel Kahn Gillmor
Reply | Threaded
Open this post in threaded view
|

[PATCH] remove debian-build/ and its children when cleaning after debian package

---
 debian/clean | 1 +
 1 file changed, 1 insertion(+)
 create mode 100644 debian/clean

diff --git a/debian/clean b/debian/clean
new file mode 100644
index 00000000..c5797567
--- /dev/null
+++ b/debian/clean
@@ -0,0 +1 @@
+debian-build/
--
2.15.1

_______________________________________________
notmuch mailing list
[hidden email]
https://notmuchmail.org/mailman/listinfo/notmuch
David Bremner-2 David Bremner-2
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] remove debian-build/ and its children when cleaning after debian package

Daniel Kahn Gillmor <[hidden email]> writes:

> ---
>  debian/clean | 1 +
>  1 file changed, 1 insertion(+)
>  create mode 100644 debian/clean
>
> diff --git a/debian/clean b/debian/clean
> new file mode 100644
> index 00000000..c5797567
> --- /dev/null
> +++ b/debian/clean
> @@ -0,0 +1 @@
> +debian-build/
> --

That seems to be something specific to git-buildpackage. The
gbp-buildpackage man page claims that the default is to remove that
directory after building. Perhaps someone more familiar with
git-buildpackage can figure out why that's not happening.

d
_______________________________________________
notmuch mailing list
[hidden email]
https://notmuchmail.org/mailman/listinfo/notmuch
Daniel Kahn Gillmor Daniel Kahn Gillmor
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] remove debian-build/ and its children when cleaning after debian package

On Sun 2018-02-04 20:34:32 -0400, David Bremner wrote:

> Daniel Kahn Gillmor <[hidden email]> writes:
>
>> ---
>>  debian/clean | 1 +
>>  1 file changed, 1 insertion(+)
>>  create mode 100644 debian/clean
>>
>> diff --git a/debian/clean b/debian/clean
>> new file mode 100644
>> index 00000000..c5797567
>> --- /dev/null
>> +++ b/debian/clean
>> @@ -0,0 +1 @@
>> +debian-build/
>> --
>
> That seems to be something specific to git-buildpackage. The
> gbp-buildpackage man page claims that the default is to remove that
> directory after building. Perhaps someone more familiar with
> git-buildpackage can figure out why that's not happening.
agreed, it is specific to git-buildpackage because of the following two
lines in debian/gbp.conf:

    # Directory for performing the build
    export-dir = ./debian-build

if gbp removed the directory after building, though, there would be no
artifacts left to review, sign or upload.  so that doesn't make sense
either.

those lines have been there since 2608bfe95 (in 2010) when
debian/gbp.conf was created.  maybe the right thing is just to remove
them, so that gbp buildpackage will default to whatever the user's
default build location is?  (usually ../, iiuc).

Any objections to removing the export-dir directive from gbp.conf?

        --dkg

_______________________________________________
notmuch mailing list
[hidden email]
https://notmuchmail.org/mailman/listinfo/notmuch

signature.asc (847 bytes) Download Attachment
David Bremner-2 David Bremner-2
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] remove debian-build/ and its children when cleaning after debian package

Daniel Kahn Gillmor <[hidden email]> writes:

> On Sun 2018-02-04 20:34:32 -0400, David Bremner wrote:
>
> agreed, it is specific to git-buildpackage because of the following two
> lines in debian/gbp.conf:
>
>     # Directory for performing the build
>     export-dir = ./debian-build
>
> if gbp removed the directory after building, though, there would be no
> artifacts left to review, sign or upload.  so that doesn't make sense
> either.
>

> Any objections to removing the export-dir directive from gbp.conf?

Not from this non-gbp-user.

d
_______________________________________________
notmuch mailing list
[hidden email]
https://notmuchmail.org/mailman/listinfo/notmuch