[PATCH] perf-tests: #!/bin/bash -> #!/usr/bin/env bash

classic Classic list List threaded Threaded
3 messages Options
William Casarin William Casarin
Reply | Threaded
Open this post in threaded view
|

[PATCH] perf-tests: #!/bin/bash -> #!/usr/bin/env bash

I couldn't run the performance tests on my machines due to a hardcoded
bash path. Use env for finding bash in weird systems like NixOS.

Signed-off-by: William Casarin <[hidden email]>
---
 performance-test/M00-new.sh             | 2 +-
 performance-test/M01-dump-restore.sh    | 2 +-
 performance-test/M02-show.sh            | 2 +-
 performance-test/M03-search.sh          | 2 +-
 performance-test/M04-reply.sh           | 2 +-
 performance-test/M05-reindex.sh         | 2 +-
 performance-test/M06-insert.sh          | 2 +-
 performance-test/T00-new.sh             | 2 +-
 performance-test/T01-dump-restore.sh    | 2 +-
 performance-test/T02-tag.sh             | 2 +-
 performance-test/T03-reindex.sh         | 2 +-
 performance-test/T04-thread-subquery.sh | 2 +-
 12 files changed, 12 insertions(+), 12 deletions(-)

diff --git a/performance-test/M00-new.sh b/performance-test/M00-new.sh
index aab36e69..5858ab33 100755
--- a/performance-test/M00-new.sh
+++ b/performance-test/M00-new.sh
@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 
 test_description='notmuch new'
 
diff --git a/performance-test/M01-dump-restore.sh b/performance-test/M01-dump-restore.sh
index 32ab8dc9..7850b411 100755
--- a/performance-test/M01-dump-restore.sh
+++ b/performance-test/M01-dump-restore.sh
@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 
 test_description='dump and restore'
 
diff --git a/performance-test/M02-show.sh b/performance-test/M02-show.sh
index 2e218fd3..40c5d4d7 100755
--- a/performance-test/M02-show.sh
+++ b/performance-test/M02-show.sh
@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 
 test_description='show'
 
diff --git a/performance-test/M03-search.sh b/performance-test/M03-search.sh
index 343f5c7c..a73a36ab 100755
--- a/performance-test/M03-search.sh
+++ b/performance-test/M03-search.sh
@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 
 test_description='search'
 
diff --git a/performance-test/M04-reply.sh b/performance-test/M04-reply.sh
index 3c1205db..3b0f9e78 100755
--- a/performance-test/M04-reply.sh
+++ b/performance-test/M04-reply.sh
@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 
 test_description='search'
 
diff --git a/performance-test/M05-reindex.sh b/performance-test/M05-reindex.sh
index 17e2c824..8ea7e7ee 100755
--- a/performance-test/M05-reindex.sh
+++ b/performance-test/M05-reindex.sh
@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 
 test_description='reindex'
 
diff --git a/performance-test/M06-insert.sh b/performance-test/M06-insert.sh
index 5ae0656a..12330c76 100755
--- a/performance-test/M06-insert.sh
+++ b/performance-test/M06-insert.sh
@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 
 test_description='search'
 
diff --git a/performance-test/T00-new.sh b/performance-test/T00-new.sh
index 25391136..a14dd13f 100755
--- a/performance-test/T00-new.sh
+++ b/performance-test/T00-new.sh
@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 
 test_description='notmuch new'
 
diff --git a/performance-test/T01-dump-restore.sh b/performance-test/T01-dump-restore.sh
index 12f12e66..2a53e3b8 100755
--- a/performance-test/T01-dump-restore.sh
+++ b/performance-test/T01-dump-restore.sh
@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 
 test_description='dump and restore'
 
diff --git a/performance-test/T02-tag.sh b/performance-test/T02-tag.sh
index 8c5dfd68..9c895d6a 100755
--- a/performance-test/T02-tag.sh
+++ b/performance-test/T02-tag.sh
@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 
 test_description='tagging'
 
diff --git a/performance-test/T03-reindex.sh b/performance-test/T03-reindex.sh
index 8e0a77f4..8db52a33 100755
--- a/performance-test/T03-reindex.sh
+++ b/performance-test/T03-reindex.sh
@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 
 test_description='reindexing'
 
diff --git a/performance-test/T04-thread-subquery.sh b/performance-test/T04-thread-subquery.sh
index 665d5a64..ba81f383 100755
--- a/performance-test/T04-thread-subquery.sh
+++ b/performance-test/T04-thread-subquery.sh
@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 
 test_description='thread subqueries'
 
--
2.21.0

_______________________________________________
notmuch mailing list
[hidden email]
https://notmuchmail.org/mailman/listinfo/notmuch
Tomi Ollila-2 Tomi Ollila-2
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] perf-tests: #!/bin/bash -> #!/usr/bin/env bash

On Fri, May 31 2019, William Casarin wrote:

> I couldn't run the performance tests on my machines due to a hardcoded
> bash path. Use env for finding bash in weird systems like NixOS.

Not so weird -- probably most non-Linux OS's that have bash,
have bash somewhere else than in /bin/.

LGTM.

Tomi

>
> Signed-off-by: William Casarin <[hidden email]>
> ---
>  performance-test/M00-new.sh             | 2 +-
>  performance-test/M01-dump-restore.sh    | 2 +-
>  performance-test/M02-show.sh            | 2 +-
>  performance-test/M03-search.sh          | 2 +-
>  performance-test/M04-reply.sh           | 2 +-
>  performance-test/M05-reindex.sh         | 2 +-
>  performance-test/M06-insert.sh          | 2 +-
>  performance-test/T00-new.sh             | 2 +-
>  performance-test/T01-dump-restore.sh    | 2 +-
>  performance-test/T02-tag.sh             | 2 +-
>  performance-test/T03-reindex.sh         | 2 +-
>  performance-test/T04-thread-subquery.sh | 2 +-
>  12 files changed, 12 insertions(+), 12 deletions(-)
>
> diff --git a/performance-test/M00-new.sh b/performance-test/M00-new.sh
> index aab36e69..5858ab33 100755
> --- a/performance-test/M00-new.sh
> +++ b/performance-test/M00-new.sh
> @@ -1,4 +1,4 @@
> -#!/bin/bash
> +#!/usr/bin/env bash
>  
>  test_description='notmuch new'
>  
> diff --git a/performance-test/M01-dump-restore.sh b/performance-test/M01-dump-restore.sh
> index 32ab8dc9..7850b411 100755
> --- a/performance-test/M01-dump-restore.sh
> +++ b/performance-test/M01-dump-restore.sh
> @@ -1,4 +1,4 @@
> -#!/bin/bash
> +#!/usr/bin/env bash
>  
>  test_description='dump and restore'
>  
> diff --git a/performance-test/M02-show.sh b/performance-test/M02-show.sh
> index 2e218fd3..40c5d4d7 100755
> --- a/performance-test/M02-show.sh
> +++ b/performance-test/M02-show.sh
> @@ -1,4 +1,4 @@
> -#!/bin/bash
> +#!/usr/bin/env bash
>  
>  test_description='show'
>  
> diff --git a/performance-test/M03-search.sh b/performance-test/M03-search.sh
> index 343f5c7c..a73a36ab 100755
> --- a/performance-test/M03-search.sh
> +++ b/performance-test/M03-search.sh
> @@ -1,4 +1,4 @@
> -#!/bin/bash
> +#!/usr/bin/env bash
>  
>  test_description='search'
>  
> diff --git a/performance-test/M04-reply.sh b/performance-test/M04-reply.sh
> index 3c1205db..3b0f9e78 100755
> --- a/performance-test/M04-reply.sh
> +++ b/performance-test/M04-reply.sh
> @@ -1,4 +1,4 @@
> -#!/bin/bash
> +#!/usr/bin/env bash
>  
>  test_description='search'
>  
> diff --git a/performance-test/M05-reindex.sh b/performance-test/M05-reindex.sh
> index 17e2c824..8ea7e7ee 100755
> --- a/performance-test/M05-reindex.sh
> +++ b/performance-test/M05-reindex.sh
> @@ -1,4 +1,4 @@
> -#!/bin/bash
> +#!/usr/bin/env bash
>  
>  test_description='reindex'
>  
> diff --git a/performance-test/M06-insert.sh b/performance-test/M06-insert.sh
> index 5ae0656a..12330c76 100755
> --- a/performance-test/M06-insert.sh
> +++ b/performance-test/M06-insert.sh
> @@ -1,4 +1,4 @@
> -#!/bin/bash
> +#!/usr/bin/env bash
>  
>  test_description='search'
>  
> diff --git a/performance-test/T00-new.sh b/performance-test/T00-new.sh
> index 25391136..a14dd13f 100755
> --- a/performance-test/T00-new.sh
> +++ b/performance-test/T00-new.sh
> @@ -1,4 +1,4 @@
> -#!/bin/bash
> +#!/usr/bin/env bash
>  
>  test_description='notmuch new'
>  
> diff --git a/performance-test/T01-dump-restore.sh b/performance-test/T01-dump-restore.sh
> index 12f12e66..2a53e3b8 100755
> --- a/performance-test/T01-dump-restore.sh
> +++ b/performance-test/T01-dump-restore.sh
> @@ -1,4 +1,4 @@
> -#!/bin/bash
> +#!/usr/bin/env bash
>  
>  test_description='dump and restore'
>  
> diff --git a/performance-test/T02-tag.sh b/performance-test/T02-tag.sh
> index 8c5dfd68..9c895d6a 100755
> --- a/performance-test/T02-tag.sh
> +++ b/performance-test/T02-tag.sh
> @@ -1,4 +1,4 @@
> -#!/bin/bash
> +#!/usr/bin/env bash
>  
>  test_description='tagging'
>  
> diff --git a/performance-test/T03-reindex.sh b/performance-test/T03-reindex.sh
> index 8e0a77f4..8db52a33 100755
> --- a/performance-test/T03-reindex.sh
> +++ b/performance-test/T03-reindex.sh
> @@ -1,4 +1,4 @@
> -#!/bin/bash
> +#!/usr/bin/env bash
>  
>  test_description='reindexing'
>  
> diff --git a/performance-test/T04-thread-subquery.sh b/performance-test/T04-thread-subquery.sh
> index 665d5a64..ba81f383 100755
> --- a/performance-test/T04-thread-subquery.sh
> +++ b/performance-test/T04-thread-subquery.sh
> @@ -1,4 +1,4 @@
> -#!/bin/bash
> +#!/usr/bin/env bash
>  
>  test_description='thread subqueries'
>  
> --
> 2.21.0
>
> _______________________________________________
> notmuch mailing list
> [hidden email]
> https://notmuchmail.org/mailman/listinfo/notmuch
_______________________________________________
notmuch mailing list
[hidden email]
https://notmuchmail.org/mailman/listinfo/notmuch
David Bremner-2 David Bremner-2
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] perf-tests: #!/bin/bash -> #!/usr/bin/env bash

In reply to this post by William Casarin
William Casarin <[hidden email]> writes:

> I couldn't run the performance tests on my machines due to a hardcoded
> bash path. Use env for finding bash in weird systems like NixOS.
>
> Signed-off-by: William Casarin <[hidden email]>

pushed to master

d
_______________________________________________
notmuch mailing list
[hidden email]
https://notmuchmail.org/mailman/listinfo/notmuch