Quantcast

[PATCH] emacs: tree: bugfix: specify --format-version

classic Classic list List threaded Threaded
2 messages Options
Mark Walters Mark Walters
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[PATCH] emacs: tree: bugfix: specify --format-version

Previously notmuch tree did not specify the format-version when
calling notmuch. This meant that when the structured output was
slightly changed (in commit 14c60cf168ac3b0f277188c16e6012b7ebdadde7)
stash filename broke. This fixes this breakage by specifying the
format-version.
---

Bremner pointed out this bug today on irc. In due course we may want
to use format-version=3 and update the helper functions but as none of
notmuch-emacs uses the new format version yet this seem the right fix for now.

Best wishes

Mark



emacs/notmuch-tree.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/emacs/notmuch-tree.el b/emacs/notmuch-tree.el
index 7bebdba..d4d4076 100644
--- a/emacs/notmuch-tree.el
+++ b/emacs/notmuch-tree.el
@@ -917,7 +917,7 @@ the same as for the function notmuch-tree."
     (notmuch-tag-clear-cache)
     (let ((proc (notmuch-start-notmuch
  "notmuch-tree" (current-buffer) #'notmuch-tree-process-sentinel
- "show" "--body=false" "--format=sexp"
+ "show" "--body=false" "--format=sexp" "--format-version=2"
  message-arg search-args))
   ;; Use a scratch buffer to accumulate partial output.
   ;; This buffer will be killed by the sentinel, which
--
2.1.4

_______________________________________________
notmuch mailing list
[hidden email]
https://notmuchmail.org/mailman/listinfo/notmuch
David Bremner-2 David Bremner-2
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [PATCH] emacs: tree: bugfix: specify --format-version

Mark Walters <[hidden email]> writes:

> Previously notmuch tree did not specify the format-version when
> calling notmuch. This meant that when the structured output was
> slightly changed (in commit 14c60cf168ac3b0f277188c16e6012b7ebdadde7)
> stash filename broke. This fixes this breakage by specifying the
> format-version.
> ---
>
> Bremner pointed out this bug today on irc. In due course we may want
> to use format-version=3 and update the helper functions but as none of
> notmuch-emacs uses the new format version yet this seem the right fix for now.

Pushed to release and master.

collecting bug fixes for a potential 0.24.2

d
_______________________________________________
notmuch mailing list
[hidden email]
https://notmuchmail.org/mailman/listinfo/notmuch
Loading...