[PATCH] cli: add support for only printing the addresses in notmuch address

classic Classic list List threaded Threaded
9 messages Options
Jani Nikula Jani Nikula
Reply | Threaded
Open this post in threaded view
|

[PATCH] cli: add support for only printing the addresses in notmuch address

The notmuch address output is much more useful for scripts with just
the addresses printed. Support this using the --output=address option.
---
 completion/notmuch-completion.bash |  2 +-
 doc/man1/notmuch-address.rst       |  7 ++++++-
 notmuch-search.c                   |  7 ++++++-
 test/T095-address.sh               | 36 ++++++++++++++++++++++++++++++++++++
 4 files changed, 49 insertions(+), 3 deletions(-)

diff --git a/completion/notmuch-completion.bash b/completion/notmuch-completion.bash
index 7aae4297ae0e..4e94275e3193 100644
--- a/completion/notmuch-completion.bash
+++ b/completion/notmuch-completion.bash
@@ -468,7 +468,7 @@ _notmuch_address()
     return
     ;;
  --output)
-    COMPREPLY=( $( compgen -W "sender recipients count" -- "${cur}" ) )
+    COMPREPLY=( $( compgen -W "sender recipients count address" -- "${cur}" ) )
     return
     ;;
  --sort)
diff --git a/doc/man1/notmuch-address.rst b/doc/man1/notmuch-address.rst
index dbac20f7b012..68415d13c5b6 100644
--- a/doc/man1/notmuch-address.rst
+++ b/doc/man1/notmuch-address.rst
@@ -29,7 +29,7 @@ Supported options for **address** include
         intended for programs that invoke **notmuch(1)** internally. If
         omitted, the latest supported version will be used.
 
-    ``--output=(sender|recipients|count)``
+    ``--output=(sender|recipients|count|address)``
 
         Controls which information appears in the output. This option
         can be given multiple times to combine different outputs.
@@ -55,6 +55,11 @@ Supported options for **address** include
             Note: With this option, addresses are printed only after
             the whole search is finished. This may take long time.
 
+        **address**
+            Output only the email addresses instead of the full
+            mailboxes with names and email addresses. This option has
+            no effect on the JSON or S-Expression output formats.
+
     ``--deduplicate=(no|mailbox|address)``
 
         Control the deduplication of results.
diff --git a/notmuch-search.c b/notmuch-search.c
index 0abac08eb7ab..8f467db43cf0 100644
--- a/notmuch-search.c
+++ b/notmuch-search.c
@@ -34,6 +34,7 @@ typedef enum {
     OUTPUT_SENDER = 1 << 5,
     OUTPUT_RECIPIENTS = 1 << 6,
     OUTPUT_COUNT = 1 << 7,
+    OUTPUT_ADDRESS = 1 << 8,
 } output_t;
 
 typedef enum {
@@ -370,7 +371,10 @@ print_mailbox (const search_context_t *ctx, const mailbox_t *mailbox)
     format->integer (format, count);
     format->string (format, "\t");
  }
- format->string (format, name_addr);
+ if (ctx->output & OUTPUT_ADDRESS)
+    format->string (format, addr);
+ else
+    format->string (format, name_addr);
  format->separator (format);
     } else {
  format->begin_map (format);
@@ -877,6 +881,7 @@ notmuch_address_command (notmuch_config_t *config, int argc, char *argv[])
   (notmuch_keyword_t []){ { "sender", OUTPUT_SENDER },
   { "recipients", OUTPUT_RECIPIENTS },
   { "count", OUTPUT_COUNT },
+  { "address", OUTPUT_ADDRESS },
   { 0, 0 } } },
  { .opt_keyword = &ctx->exclude, .name = "exclude", .keywords =
   (notmuch_keyword_t []){ { "true", NOTMUCH_EXCLUDE_TRUE },
diff --git a/test/T095-address.sh b/test/T095-address.sh
index f0291d29ec43..817be5380a45 100755
--- a/test/T095-address.sh
+++ b/test/T095-address.sh
@@ -119,6 +119,42 @@ cat <<EOF >EXPECTED
 EOF
 test_expect_equal_file EXPECTED OUTPUT
 
+test_begin_subtest "--output=recipients --output=address"
+notmuch address --output=recipients --output=address '*' >OUTPUT
+cat <<EOF >EXPECTED
+[hidden email]
+[hidden email]
+[hidden email]
+[hidden email]
+[hidden email]
+[hidden email]
+[hidden email]
+EOF
+test_expect_equal_file EXPECTED OUTPUT
+
+test_begin_subtest "--output=sender --output=address --output=count"
+notmuch address --output=sender --output=address --output=count '*' | sort -n >OUTPUT
+cat <<EOF >EXPECTED
+1 [hidden email]
+1 [hidden email]
+1 [hidden email]
+1 [hidden email]
+1 [hidden email]
+1 [hidden email]
+1 [hidden email]
+1 [hidden email]
+2 [hidden email]
+2 [hidden email]
+3 [hidden email]
+4 [hidden email]
+4 [hidden email]
+5 [hidden email]
+5 [hidden email]
+7 [hidden email]
+12 [hidden email]
+EOF
+test_expect_equal_file EXPECTED OUTPUT
+
 test_begin_subtest "--output=count --format=json"
 # Since the iteration order of GHashTable is not specified, we
 # preprocess and sort the results to keep the order stable here.
--
2.11.0

_______________________________________________
notmuch mailing list
[hidden email]
https://notmuchmail.org/mailman/listinfo/notmuch
David Bremner-2 David Bremner-2
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] cli: add support for only printing the addresses in notmuch address

Jani Nikula <[hidden email]> writes:

> The notmuch address output is much more useful for scripts with just
> the addresses printed. Support this using the --output=address option.

pushed to master

d
_______________________________________________
notmuch mailing list
[hidden email]
https://notmuchmail.org/mailman/listinfo/notmuch
Jameson Graef Rollins Jameson Graef Rollins
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] cli: add support for only printing the addresses in notmuch address

In reply to this post by Jani Nikula
On Thu, Nov 02 2017, Jani Nikula <[hidden email]> wrote:
> The notmuch address output is much more useful for scripts with just
> the addresses printed. Support this using the --output=address option.

Isn't "address" kind of orthogonal to "sender" and "recipient"?  Isn't
this more like the --output/--format distinction in search?

jamie.

_______________________________________________
notmuch mailing list
[hidden email]
https://notmuchmail.org/mailman/listinfo/notmuch

signature.asc (847 bytes) Download Attachment
Daniel Kahn Gillmor Daniel Kahn Gillmor
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] cli: add support for only printing the addresses in notmuch address

On Tue 2017-12-19 13:23:55 -0800, Jameson Graef Rollins wrote:
> On Thu, Nov 02 2017, Jani Nikula <[hidden email]> wrote:
>> The notmuch address output is much more useful for scripts with just
>> the addresses printed. Support this using the --output=address option.
>
> Isn't "address" kind of orthogonal to "sender" and "recipient"?  Isn't
> this more like the --output/--format distinction in search?

i think i agree with Jamie here -- it'd be nice to be able to ask for
the addresses of the senders, or the addresses of the recipients.  how
would that be done here?

      --dkg
_______________________________________________
notmuch mailing list
[hidden email]
https://notmuchmail.org/mailman/listinfo/notmuch
Jameson Graef Rollins Jameson Graef Rollins
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] cli: add support for only printing the addresses in notmuch address

On Tue, Dec 19 2017, Daniel Kahn Gillmor <[hidden email]> wrote:

> On Tue 2017-12-19 13:23:55 -0800, Jameson Graef Rollins wrote:
>> On Thu, Nov 02 2017, Jani Nikula <[hidden email]> wrote:
>>> The notmuch address output is much more useful for scripts with just
>>> the addresses printed. Support this using the --output=address option.
>>
>> Isn't "address" kind of orthogonal to "sender" and "recipient"?  Isn't
>> this more like the --output/--format distinction in search?
>
> i think i agree with Jamie here -- it'd be nice to be able to ask for
> the addresses of the senders, or the addresses of the recipients.  how
> would that be done here?
Sorry, I see now that address already has the --format option with the
expected values.  So I think either address-only or sender/recipient
should be a separate option.

jamie.

_______________________________________________
notmuch mailing list
[hidden email]
https://notmuchmail.org/mailman/listinfo/notmuch

signature.asc (847 bytes) Download Attachment
Jani Nikula Jani Nikula
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] cli: add support for only printing the addresses in notmuch address

On Tue, 19 Dec 2017, Jameson Graef Rollins <[hidden email]> wrote:

> On Tue, Dec 19 2017, Daniel Kahn Gillmor <[hidden email]> wrote:
>> On Tue 2017-12-19 13:23:55 -0800, Jameson Graef Rollins wrote:
>>> On Thu, Nov 02 2017, Jani Nikula <[hidden email]> wrote:
>>>> The notmuch address output is much more useful for scripts with just
>>>> the addresses printed. Support this using the --output=address option.
>>>
>>> Isn't "address" kind of orthogonal to "sender" and "recipient"?  Isn't
>>> this more like the --output/--format distinction in search?
>>
>> i think i agree with Jamie here -- it'd be nice to be able to ask for
>> the addresses of the senders, or the addresses of the recipients.  how
>> would that be done here?
>
> Sorry, I see now that address already has the --format option with the
> expected values.  So I think either address-only or sender/recipient
> should be a separate option.

Note that you can give the notmuch address --output option multiple
times to control the output. For example,

~$ notmuch address --output=sender --output=recipients id:[hidden email]
Jameson Graef Rollins <[hidden email]>
Daniel Kahn Gillmor <[hidden email]>
Jani Nikula <[hidden email]>
[hidden email]

~$ notmuch address --output=recipients --output=address id:[hidden email]
[hidden email]
[hidden email]
[hidden email]

~$ notmuch address --output=sender --output=recipients --output=address --output=count id:[hidden email]
1 [hidden email]
1 [hidden email]
1 [hidden email]
1 [hidden email]

I prefer this to separate options.

notmuch search uses separate --entire-thread, --body, and --include-html
options, and I think those are getting messy.

BR,
Jani.
_______________________________________________
notmuch mailing list
[hidden email]
https://notmuchmail.org/mailman/listinfo/notmuch
Jameson Graef Rollins Jameson Graef Rollins
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] cli: add support for only printing the addresses in notmuch address

On Wed, Dec 20 2017, Jani Nikula <[hidden email]> wrote:
> ~$ notmuch address --output=sender --output=recipients --output=address --output=count id:[hidden email]
> 1 [hidden email]
> 1 [hidden email]
> 1 [hidden email]
> 1 [hidden email]
>
> I prefer this to separate options.

Really?  If each is just a switch then why not:

~$ notmuch address --sender --recipients --address --count id:[hidden email]

?  It's just shorter, right?

Also, this behavior is quite different than for search, in which only
the last --output applies.

> notmuch search uses separate --entire-thread, --body, and --include-html
> options, and I think those are getting messy.

The seem less messy than a "--output=" prefixed version of the same.

jamie.

_______________________________________________
notmuch mailing list
[hidden email]
https://notmuchmail.org/mailman/listinfo/notmuch

signature.asc (847 bytes) Download Attachment
Jani Nikula Jani Nikula
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] cli: add support for only printing the addresses in notmuch address

On Tue, 19 Dec 2017, Jameson Graef Rollins <[hidden email]> wrote:

> On Wed, Dec 20 2017, Jani Nikula <[hidden email]> wrote:
>> ~$ notmuch address --output=sender --output=recipients --output=address --output=count id:[hidden email]
>> 1 [hidden email]
>> 1 [hidden email]
>> 1 [hidden email]
>> 1 [hidden email]
>>
>> I prefer this to separate options.
>
> Really?  If each is just a switch then why not:
>
> ~$ notmuch address --sender --recipients --address --count id:[hidden email]
>
> ?  It's just shorter, right?
>
> Also, this behavior is quite different than for search, in which only
> the last --output applies.
>
>> notmuch search uses separate --entire-thread, --body, and --include-html
>> options, and I think those are getting messy.

That was supposed to be notmuch show, not search.

> The seem less messy than a "--output=" prefixed version of the same.

Matter of taste. I like the self-documenting aspect of *what* these
options control. --output=body is obvious, --body is less
so. --include-html includes html somewhere, I think --output=html would
be better.

In the spirit of worse is better, I'll note that using --output= stores
all the possible values in a single bit mask, and it's easy to define
the defaults for *all* possible outputs in one variable, and it's easy
to check *all* possible combinations with bit masks. Not so with
independent parameters. Again, matter of taste how much you appreciate
implementation simplicity. With notmuch show, I think that guideline
would have made the interface better too. YMMV.

As to notmuch address --output=address, it fulfills all the feature
needs that popped up in this thread. If there's a strong desired to
change the interface, we'll need patches as this one's already merged.

BR,
Jani.
_______________________________________________
notmuch mailing list
[hidden email]
https://notmuchmail.org/mailman/listinfo/notmuch
Jameson Graef Rollins Jameson Graef Rollins
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] cli: add support for only printing the addresses in notmuch address

On Wed, Dec 20 2017, Jani Nikula <[hidden email]> wrote:

> Matter of taste. I like the self-documenting aspect of *what* these
> options control. --output=body is obvious, --body is less
> so. --include-html includes html somewhere, I think --output=html would
> be better.
>
> In the spirit of worse is better, I'll note that using --output= stores
> all the possible values in a single bit mask, and it's easy to define
> the defaults for *all* possible outputs in one variable, and it's easy
> to check *all* possible combinations with bit masks. Not so with
> independent parameters. Again, matter of taste how much you appreciate
> implementation simplicity. With notmuch show, I think that guideline
> would have made the interface better too. YMMV.
>
> As to notmuch address --output=address, it fulfills all the feature
> needs that popped up in this thread. If there's a strong desired to
> change the interface, we'll need patches as this one's already merged.
I'm less interested in specific argument formatting than I am in
consistency across the interface.  I just don't like how --output= now
has quite different semantics between the different sub commands.  That
seems like the wrong direction to me.

jamie.

_______________________________________________
notmuch mailing list
[hidden email]
https://notmuchmail.org/mailman/listinfo/notmuch

signature.asc (847 bytes) Download Attachment