[PATCH] build: fix unbound variable in configure

classic Classic list List threaded Threaded
3 messages Options
Jan Malakhovski Jan Malakhovski
Reply | Threaded
Open this post in threaded view
|

[PATCH] build: fix unbound variable in configure

---
 configure | 1 +
 1 file changed, 1 insertion(+)

diff --git a/configure b/configure
index 364854f3..c0a550c7 100755
--- a/configure
+++ b/configure
@@ -651,6 +651,7 @@ if command -v cppcheck > /dev/null; then
     have_cppcheck=1
     printf "Yes.\n"
 else
+    have_cppcheck=0
     printf "No.\n"
 fi
 
--
2.14.1

_______________________________________________
notmuch mailing list
[hidden email]
https://notmuchmail.org/mailman/listinfo/notmuch
David Bremner-2 David Bremner-2
Reply | Threaded
Open this post in threaded view
|

[PATCH] configure: add missing initialization of have_cppcheck

This missing initialization causes configure to crash, and hence the
build to fail in environments without cppcheck.
---
 configure | 1 +
 1 file changed, 1 insertion(+)

diff --git a/configure b/configure
index 364854f3..3ca1fcab 100755
--- a/configure
+++ b/configure
@@ -646,6 +646,7 @@ if [ $WITH_DESKTOP = "1" ]; then
     fi
 fi
 
+have_cppcheck=0
 printf "Checking for cppcheck... "
 if command -v cppcheck > /dev/null; then
     have_cppcheck=1
--
2.11.0

_______________________________________________
notmuch mailing list
[hidden email]
https://notmuchmail.org/mailman/listinfo/notmuch
David Bremner-2 David Bremner-2
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] build: fix unbound variable in configure

In reply to this post by Jan Malakhovski
Jan Malakhovski <[hidden email]> writes:

> ---
>  configure | 1 +
>  1 file changed, 1 insertion(+)

Thanks! I've pushed your fix, with some extra comments that I wrote more
or less in parallel.

d
_______________________________________________
notmuch mailing list
[hidden email]
https://notmuchmail.org/mailman/listinfo/notmuch