[PATCH] Older versions of install do not support -C.

classic Classic list List threaded Threaded
2 messages Options
Jan Janak-2 Jan Janak-2
Reply | Threaded
Open this post in threaded view
|

[PATCH] Older versions of install do not support -C.

Do not use -C cmdline option of install, older versions, commonly found in
distributions like Debian, do not seem to support it. Running make install
on such systems (tested on Debian Lenny) fails.

Signed-off-by: Jan Janak <[hidden email]>
---
 Makefile.local |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/Makefile.local b/Makefile.local
index f824bed..f51f1d1 100644
--- a/Makefile.local
+++ b/Makefile.local
@@ -27,11 +27,11 @@ install: all notmuch.1.gz
  for d in $(DESTDIR)$(prefix)/bin/ $(DESTDIR)$(prefix)/share/man/man1 \
  $(DESTDIR)/etc/bash_completion.d/ ; \
  do \
- install -C -d $$d ; \
+ install -d $$d ; \
  done ;
- install -C notmuch $(DESTDIR)$(prefix)/bin/
- install -C -m0644 notmuch.1.gz $(DESTDIR)$(prefix)/share/man/man1/
- install -C notmuch-completion.bash \
+ install notmuch $(DESTDIR)$(prefix)/bin/
+ install -m0644 notmuch.1.gz $(DESTDIR)$(prefix)/share/man/man1/
+ install notmuch-completion.bash \
  $(DESTDIR)/etc/bash_completion.d/notmuch
 
 SRCS  := $(SRCS) $(notmuch_client_srcs)
--
1.6.3.3


Carl Worth-2 Carl Worth-2
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] Older versions of install do not support -C.

On Tue, 17 Nov 2009 23:18:47 +0100, Jan Janak <[hidden email]> wrote:
> Do not use -C cmdline option of install, older versions, commonly found in
> distributions like Debian, do not seem to support it. Running make install
> on such systems (tested on Debian Lenny) fails.
>
> Signed-off-by: Jan Janak <[hidden email]>

Thanks, Jan. This is pushed now.

And did I say welcome to notmuch yet? (It's easy to lose track with all
the newcomers---which I'm not complaining about---especially since so
many are sharing code.)

-Carl

PS. I actually really like the behavior of -C (especially when
installing a low-level library to avoid big waterfalls of needless
recompiles). But since we're *not* actually installing a library (yet)
I'm happy with this patch rather than writing code in configure to check
if "install -C" works or not.