[PATCH] Missing final semi-colon in .desktop's Categories.

classic Classic list List threaded Threaded
3 messages Options
James Rowe James Rowe
Reply | Threaded
Open this post in threaded view
|

[PATCH] Missing final semi-colon in .desktop's Categories.

"Those keys which have several values should have a semicolon as the trailing
character."
  -- http://standards.freedesktop.org/desktop-entry-spec/1.0/ar01s03.html

Signed-off-by: James Rowe <[hidden email]>
---
 notmuch.desktop |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/notmuch.desktop b/notmuch.desktop
index d29dff6..819cd1e 100644
--- a/notmuch.desktop
+++ b/notmuch.desktop
@@ -4,4 +4,4 @@ Exec=emacs -f notmuch
 Icon=emblem-mail
 Terminal=false
 Type=Application
-Categories=Network;Email
+Categories=Network;Email;
--
1.6.4.4


Jeffrey Ollie Jeffrey Ollie
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] Missing final semi-colon in .desktop's Categories.

Found the same problem on my own, only to minutes later catch up on
the backlog of patches in my email and find this!

On Sat, Nov 21, 2009 at 3:13 AM, James Rowe <[hidden email]> wrote:
> "Those keys which have several values should have a semicolon as the trailing
> character."
>  -- http://standards.freedesktop.org/desktop-entry-spec/1.0/ar01s03.html
>
> Signed-off-by: James Rowe <[hidden email]>

Reviewed-by: Jeffrey C. Ollie <[hidden email]>

> ---
>  notmuch.desktop |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/notmuch.desktop b/notmuch.desktop
> index d29dff6..819cd1e 100644
> --- a/notmuch.desktop
> +++ b/notmuch.desktop
> @@ -4,4 +4,4 @@ Exec=emacs -f notmuch
>  Icon=emblem-mail
>  Terminal=false
>  Type=Application
> -Categories=Network;Email
> +Categories=Network;Email;
> --
> 1.6.4.4
>
> _______________________________________________
> notmuch mailing list
> [hidden email]
> http://notmuchmail.org/mailman/listinfo/notmuch
>



--
Jeff Ollie

Carl Worth-2 Carl Worth-2
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] Missing final semi-colon in .desktop's Categories.

On Sun, 22 Nov 2009 01:07:49 -0600, Jeffrey Ollie <[hidden email]> wrote:
> Found the same problem on my own, only to minutes later catch up on
> the backlog of patches in my email and find this!
...
> > Signed-off-by: James Rowe <[hidden email]>
>
> Reviewed-by: Jeffrey C. Ollie <[hidden email]>

Much thanks, James and Jeffrey!

I always feel *much* more comfortable pushing a patch I haven't tested
personally if someone else has reviewed it.

-Carl