[PATCH] Avoid spurious gcc warning in debugger.c

classic Classic list List threaded Threaded
5 messages Options
Daniel Kahn Gillmor Daniel Kahn Gillmor
Reply | Threaded
Open this post in threaded view
|

[PATCH] Avoid spurious gcc warning in debugger.c

Without this patch, gcc 8.2.0-7 complains:

debugger.c: In function ‘debugger_is_active’:
debugger.c:40:24: warning: passing argument 2 to restrict-qualified parameter aliases with argument 1 [-Wrestrict]
     if (readlink (buf, buf, sizeof (buf)) != -1 &&
                   ~~~  ^~~

This is pretty silly, but it seems simplest to just avoid passing the
same buffer to readlink as both pathname and buf.
---
 debugger.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/debugger.c b/debugger.c
index 5cb38ac4..0febf170 100644
--- a/debugger.c
+++ b/debugger.c
@@ -32,13 +32,14 @@ bool
 debugger_is_active (void)
 {
     char buf[1024];
+    char buf2[1024];
 
     if (RUNNING_ON_VALGRIND)
  return true;
 
     sprintf (buf, "/proc/%d/exe", getppid ());
-    if (readlink (buf, buf, sizeof (buf)) != -1 &&
- strncmp (basename (buf), "gdb", 3) == 0)
+    if (readlink (buf, buf2, sizeof (buf2)) != -1 &&
+ strncmp (basename (buf2), "gdb", 3) == 0)
     {
  return true;
     }
--
2.19.0

_______________________________________________
notmuch mailing list
[hidden email]
https://notmuchmail.org/mailman/listinfo/notmuch
David Bremner-2 David Bremner-2
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] Avoid spurious gcc warning in debugger.c

Daniel Kahn Gillmor <[hidden email]> writes:

> Without this patch, gcc 8.2.0-7 complains:
>
> debugger.c: In function ‘debugger_is_active’:
> debugger.c:40:24: warning: passing argument 2 to restrict-qualified parameter aliases with argument 1 [-Wrestrict]
>      if (readlink (buf, buf, sizeof (buf)) != -1 &&
>                    ~~~  ^~~
>

There seems to be some overlap with dme's recent patch

      id:[hidden email]

Could one or both of you maybe produce a merged series?

d
_______________________________________________
notmuch mailing list
[hidden email]
https://notmuchmail.org/mailman/listinfo/notmuch
David Edmondson David Edmondson
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] Avoid spurious gcc warning in debugger.c

On Monday, 2018-10-08 at 12:42:18 -03, David Bremner wrote:

> Daniel Kahn Gillmor <[hidden email]> writes:
>
>> Without this patch, gcc 8.2.0-7 complains:
>>
>> debugger.c: In function ‘debugger_is_active’:
>> debugger.c:40:24: warning: passing argument 2 to restrict-qualified parameter aliases with argument 1 [-Wrestrict]
>>      if (readlink (buf, buf, sizeof (buf)) != -1 &&
>>                    ~~~  ^~~
>>
>
> There seems to be some overlap with dme's recent patch
>
>       id:[hidden email]
>
> Could one or both of you maybe produce a merged series?

The change is really the same.

dme.
--
I just bite it, it's for the look I don't light it.
_______________________________________________
notmuch mailing list
[hidden email]
https://notmuchmail.org/mailman/listinfo/notmuch
Daniel Kahn Gillmor Daniel Kahn Gillmor
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] Avoid spurious gcc warning in debugger.c

On Mon 2018-10-08 16:47:08 +0100, David Edmondson wrote:

> On Monday, 2018-10-08 at 12:42:18 -03, David Bremner wrote:
>
>> Daniel Kahn Gillmor <[hidden email]> writes:
>>
>>> Without this patch, gcc 8.2.0-7 complains:
>>>
>>> debugger.c: In function ‘debugger_is_active’:
>>> debugger.c:40:24: warning: passing argument 2 to restrict-qualified parameter aliases with argument 1 [-Wrestrict]
>>>      if (readlink (buf, buf, sizeof (buf)) != -1 &&
>>>                    ~~~  ^~~
>>>
>>
>> There seems to be some overlap with dme's recent patch
>>
>>       id:[hidden email]
>>
>> Could one or both of you maybe produce a merged series?
>
> The change is really the same.

i'm fine with either one as well.  thanks, and sorry that i missed dme's
proposal when preparing this one.

    --dkg
_______________________________________________
notmuch mailing list
[hidden email]
https://notmuchmail.org/mailman/listinfo/notmuch
David Bremner-2 David Bremner-2
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] Avoid spurious gcc warning in debugger.c

In reply to this post by Daniel Kahn Gillmor
Daniel Kahn Gillmor <[hidden email]> writes:

> Without this patch, gcc 8.2.0-7 complains:
>
> debugger.c: In function ‘debugger_is_active’:
> debugger.c:40:24: warning: passing argument 2 to restrict-qualified parameter aliases with argument 1 [-Wrestrict]
>      if (readlink (buf, buf, sizeof (buf)) != -1 &&
>                    ~~~  ^~~
>
> This is pretty silly, but it seems simplest to just avoid passing the
> same buffer to readlink as both pathname and buf.

pushed,

d
_______________________________________________
notmuch mailing list
[hidden email]
https://notmuchmail.org/mailman/listinfo/notmuch