Fwd: Delivery Status Notification (Failure)

classic Classic list List threaded Threaded
5 messages Options
Tomi Ollila-5 Tomi Ollila-5
Reply | Threaded
Open this post in threaded view
|

Fwd: Delivery Status Notification (Failure)


Sorry for the mess -- too tired to fight with this -- hopefully the content is readable below (will not know before mail leaves...)

Virhekuvake

Viestiä ei toimitettu

Olet lähettämässä viestiä toisesta osoitteesta tai aliaksesta Lähetysosoite-ominaisuudella. Lähetysosoite-tilin asetukset ovat virheelliset tai vanhentuneet. Tarkista kyseisen tilin asetukset ja yritä lähettää viesti uudelleen.
LISÄTIETOJA




---------- Forwarded message ----------
From: Tomi Ollila <[hidden email]>
To: [hidden email]
Cc: 
Bcc: 
Date: Fri, 14 Jun 2019 23:11:47 +0300
Subject: Re: [PATCH] configure: fix mktemp call for macOS
Hi

cannot (easily) attach to the thread from this account, therefore...

First, it would be better if

TEMP_GPG=$(mktemp -d "${TMPDIR:-/tmp}/notmuch.XXXXXX")

worked, then the behaviour on Linux would not change.


To me it looks like the problem in that one debian bug (i847206) is that the
directory pathname is already like 106 octets -- and on Linux the maximun
unix domain socket pathname is 108 octets -- gpg socket is probably longer
than 1 octet here :D

In case of macOS (and BSD, so says internet) max pathname is 104 octets

In Ralph's example $TMPDIR is

/var/folders/m_/w5lk3r_1495dhnl4l0s96pr00000gn/T/

-- 50 octets. Also probably older system would not have so much longer
tmpdir settings that appending gpg socket name would make length pass
104 octets...

But I am not personally against "hardcoding" /tmp/ (i.e. ignoring TMPDIR) as
prefix location where temporary directory for GNUPGHOME is created
(and, again I don't see where it could fail (barring cases similar to xkcd
 workflow)), but perhaps the behavioural change could be mentioned in
the commit message.

(BTW: in case of clutter, by default $TMPDIR is not set, and if set then user is
responsible of cleaning the clutter. if macOS does its own magic with
$TMPDIR (i.e. w/o user's intervention) then os should also take care
of the clutter...)

(BTW2: I was about to claim that ./configure in notmuch removes GNUPGHOME
 quickly after its use has ended, but I did not look anything doing that...)


Tomi

_______________________________________________
notmuch mailing list
[hidden email]
https://notmuchmail.org/mailman/listinfo/notmuch
Ralph Seichter-2 Ralph Seichter-2
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] configure: fix mktemp call for macOS

* Tomi Ollila:

> First, it would be better if
>
> TEMP_GPG=$(mktemp -d "${TMPDIR:-/tmp}/notmuch.XXXXXX")
>
> worked, then the behaviour on Linux would not change.

I'm trying to figure out if I can override $TMPDIR during the MacPorts
configure phase. According to the documentation, modifying environment
variables should work, but I am not quite there yet.

Corollary: I suggest we go for the method shown above for the time
being. I am not a fan of hardcoding paths either.

-Ralph
_______________________________________________
notmuch mailing list
[hidden email]
https://notmuchmail.org/mailman/listinfo/notmuch
Tomi Ollila-2 Tomi Ollila-2
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] configure: fix mktemp call for macOS

On Sat, Jun 15 2019, Ralph Seichter wrote:

> * Tomi Ollila:
>
>> First, it would be better if
>>
>> TEMP_GPG=$(mktemp -d "${TMPDIR:-/tmp}/notmuch.XXXXXX")
>>
>> worked, then the behaviour on Linux would not change.
>
> I'm trying to figure out if I can override $TMPDIR during the MacPorts
> configure phase. According to the documentation, modifying environment
> variables should work, but I am not quite there yet.
>
> Corollary: I suggest we go for the method shown above for the time
> being. I am not a fan of hardcoding paths either.

That maintains the status quo, so no-one needs to explain the change
in commit message.

SO I pre-LGTM anyone sending message containing the followin change:

+    if ! TEMP_GPG=$(mktemp -d "${TMPDIR:-/tmp}/notmuch.XXXXXX"); then

Tomi


>
> -Ralph
_______________________________________________
notmuch mailing list
[hidden email]
https://notmuchmail.org/mailman/listinfo/notmuch
Ralph Seichter-2 Ralph Seichter-2
Reply | Threaded
Open this post in threaded view
|

[PATCH] configure: fix mktemp call for macOS

Add missing template to mktemp, as required by macOS / OS X.

Signed-off-by: Ralph Seichter <[hidden email]>
---
 configure | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/configure b/configure
index 8b80f0e0..6e73b22e 100755
--- a/configure
+++ b/configure
@@ -529,7 +529,7 @@ int main () {
     return 0;
 }
 EOF
-    if ! TEMP_GPG=$(mktemp -d); then
+    if ! TEMP_GPG=$(mktemp -d "${TMPDIR:-/tmp}/notmuch.XXXXXX"); then
         printf 'No.\nCould not make tempdir for testing session-key support.\n'
         errors=$((errors + 1))
     elif ${CC} ${CFLAGS} ${gmime_cflags} _check_session_keys.c ${gmime_ldflags} -o _check_session_keys \
--
2.22.0

(This obsoletes id:[hidden email])
_______________________________________________
notmuch mailing list
[hidden email]
https://notmuchmail.org/mailman/listinfo/notmuch
David Bremner-2 David Bremner-2
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] configure: fix mktemp call for macOS

Ralph Seichter <[hidden email]> writes:

> Add missing template to mktemp, as required by macOS / OS X.
>
> Signed-off-by: Ralph Seichter <[hidden email]>
> ---

I've merged this to master and release. In the case that we do another
point release before 0.30, it will be in that.

d
_______________________________________________
notmuch mailing list
[hidden email]
https://notmuchmail.org/mailman/listinfo/notmuch